Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.94%. Comparing base (30dee49) to head (ba83468).
⚠️ Report is 1 commits behind head on master.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   87.25%   88.94%   +1.68%     
==========================================
  Files           5        6       +1     
  Lines         361      416      +55     
==========================================
+ Hits          315      370      +55     
  Misses         46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

related to jump-dev/MathOptInterface.jl#1940

@odow, we should only support MOI to a single LP form. The other conversions should follow from that point.

@blegat, currently the conic geometric form is very flexible here. a change to MatrixOfConstraints would limit the available sets to a fixed subset, right? Have you thought about that?

I think MatrixOptInterface should do the matrix conversion to MOI both ways.
Before this PR, it was able to do
1 - MOI to matrix for conic programs
2 - matrix to MOI for linear programs

after this, MatOI will be able to do
3 - MOI to matrix for linear programs

it will be missing:
4 - matrix to MOI for conic programs

currently the conic geometric form is very flexible here. a change to MatrixOfConstraints would limit the available sets to a fixed subset, right? Have you thought about that?

We can move https://github.com/jump-dev/DiffOpt.jl/blob/master/src/product_of_sets.jl to this repo and use it for the conic version.